Repository navigation
Let the comment toolbar scroll horizontally on mobile - #4778
Conversation
The Post button was clipped in portrait because the composer toolbar is one row inside an overflow-hidden card. Co-authored-by: Steven Tey <steven@dub.co>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the main change: enabling horizontal scrolling for the comment toolbar on mobile. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Summary
On a phone in portrait, the submitted-lead comment toolbar is wider than the sheet. The formatting controls and the "Workspace and partner" option fill the row, and the Post button is clipped. Turning the phone sideways makes it wide enough to fit.
The composer now stays within the card, and that toolbar row scrolls horizontally so Post can be reached without rotating the phone. When the row already fits, the controls stay spaced the same way as before.
Test
Checked the same layout in Chrome at a 390px phone width: the toolbar scrolls, and Post is fully visible after scrolling to the end. At a landscape width the row does not scroll and Post stays on the right.
Slack Thread
Summary by CodeRabbit